Improving the menu #2156
Merged
Improving the menu #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed some icons; - 2 new custom icons; - Rename "Query List" to "Search Adlists" Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
|
Before:
After:
|
yubiuser
reviewed
Mar 22, 2022
There was a problem hiding this comment.
I'm fine with most changes. However, I don't like the user-clock icon. It's the only one with an animation and doesn't really fit within the others. How about fa-timer or hourglass-clock?
Would it be possible to have the custom svgs as files and not directly in the source code?
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
|
It was a typo (I have no idea how this got deleted). |
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1 |
This was referenced Apr 20, 2022
1 task
1 task
This was referenced Apr 24, 2022
This was referenced Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase)git commit --signoff)What does this PR aim to accomplish?:
This PR tries to improve the menu.
How does this PR accomplish the above?:
Minor visual changes to the menu:
Screenshot
What documentation changes (if any) are needed to support this PR?:
none (maybe replace a few screenshots)