Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVG icons dimensions #2176

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Fix SVG icons dimensions #2176

merged 1 commit into from
Apr 21, 2022

Conversation

rdwebdesign
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Fix #2175

How does this PR accomplish the above?:

Use the correct height to size the icons.

What documentation changes (if any) are needed to support this PR?:

none

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@yubiuser
Copy link
Member

Approving based on code. Maybe someone (@PromoFaux) who actually saw this screen flicker can confirm it's working in reality.

@PromoFaux PromoFaux self-requested a review April 21, 2022 07:42
@PromoFaux
Copy link
Member

Will check later when I'm home!

Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto

@PromoFaux PromoFaux merged commit 50261e5 into devel Apr 21, 2022
@PromoFaux PromoFaux deleted the fix/svg_size branch April 21, 2022 17:40
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-16-web-v5-13-and-core-v5-11-1-released/56384/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants