Also check wildcard domains for validity before adding #2212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
So far, we do not check the domain for validity if the
wildcard
checkbox is selected. This made it possible to enter anything into the input box without being checked.How does this PR accomplish the above?:
Check input for validity always (except it is a regex, meaning type 2 or 3), and do the wildcard conversion after the check has been performed.
Types according to
https://github.com/pi-hole/AdminLTE/blob/6c320a42574f9f0944ded71d84b7331557dbc6ea/scripts/pi-hole/js/groups-domains.js#L342-L354
What documentation changes (if any) are needed to support this PR?:
None