Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak/readme logo #2269

Merged
merged 2 commits into from
Jul 23, 2022
Merged

Tweak/readme logo #2269

merged 2 commits into from
Jul 23, 2022

Conversation

rdwebdesign
Copy link
Member

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions

What does this PR aim to accomplish?:

Add code to choose the right logo for dark themes.

How does this PR accomplish the above?:

Following the instructions from here.

What documentation changes (if any) are needed to support this PR?:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@yubiuser
Copy link
Member

We also need to change this in the core repo. (pi-hole/pi-hole#4735)
It still uses #gh-dark-mode-only which is considered deprecated

The old method of specifying images based on the theme, by using a fragment appended to the URL (#gh-dark-mode-only or #gh-light-mode-only), is deprecated and will be removed in favor of the new method described above.

@yubiuser yubiuser merged commit 0f7f9db into devel Jul 23, 2022
@yubiuser yubiuser deleted the tweak/readme_logo branch July 23, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants