Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove email functionality #2301

Merged
merged 2 commits into from
Aug 21, 2022
Merged

Remove email functionality #2301

merged 2 commits into from
Aug 21, 2022

Conversation

yubiuser
Copy link
Member

  • What does this PR aim to accomplish?:

Removes the email functionality from the web interface. For details see the corresponding core PR: pi-hole/pi-hole#4870

Bildschirmfoto zu 2022-08-17 23-11-38

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser
Remove email functionality
e32bc2d 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Aug 17, 2022
@yubiuser yubiuser requested a review from a team August 17, 2022 21:24
@yubiuser yubiuser mentioned this pull request Aug 17, 2022
Merged
1 task
@yubiuser yubiuser added PR: Approved Open Pull Request, Approved by required number of reviewers and removed PR: Approval Required Open Pull Request, needs approval labels Aug 20, 2022
@yubiuser yubiuser merged commit c6b64ae into devel Aug 21, 2022
@yubiuser yubiuser deleted the email branch August 21, 2022 08:11
@yubiuser yubiuser mentioned this pull request Aug 23, 2022
Merged
1 task
yubiuser added a commit to pi-hole/pi-hole that referenced this pull request Aug 24, 2022
@yubiuser
Remove the email function (#4870)
66eeee5 
- **What does this PR aim to accomplish?:**

We offered to set an administrator email which was shown on the blockpage. With the removal of the blockpage (#3910) this function is not needed anymore.

Corresponding web interface PR: pi-hole/web#2301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdwebdesign rdwebdesign rdwebdesign approved these changes

Assignees
No one assigned
Labels
PR: Approved Open Pull Request, Approved by required number of reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yubiuser @rdwebdesign