Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecssary <br> from adlist details #2319

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Sep 1, 2022

  • What does this PR aim to accomplish?:

Removes an unnecessary <br> between date and time in adlist details when on mobile.

  • How does this PR accomplish the above?:

Set false flag in utils.datetime to remove the break.
https://github.com/pi-hole/AdminLTE/blob/1714b082c3a233ea3a0c344b50352c59818676fc/scripts/pi-hole/js/utils.js#L135-L137

Before:
Bildschirmfoto zu 2022-09-01 07-21-01

After:
Bildschirmfoto zu 2022-09-01 07-23-56


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team September 1, 2022 05:31
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Sep 1, 2022
Signed-off-by: Christian König <ckoenig@posteo.de>
@PromoFaux PromoFaux merged commit eff52d6 into devel Sep 2, 2022
@PromoFaux PromoFaux deleted the fix/adlist_break branch September 2, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants