-
-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default value for $ver in func.php #2497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value can also be an empty string.
What do you think it's better?
Note:
this function will return this default value only if the file doesn't exist, but I think this will happen only if something is really broken, because the web interface should always have all files.
Signed-off-by: Christian König <ckoenig@posteo.de> Co-authored-by: ElectronicsTinkerer <ElectronicsTinkerer@users.noreply.github.com>
Mhh.. you are the web developer. I have no opinion on |
The question is almost stupid (it's just a preference): What do you think is better to have in case of "file not found"? <link rel="stylesheet" href="style/pi-hole.css?v=0">
or
<link rel="stylesheet" href="style/pi-hole.css?v=">
or something else
<link rel="stylesheet" href="style/pi-hole.css?v=not_found"> Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-web-v5-18-2-and-core-v5-15-1-released/60695/1 |
What does this PR aim to accomplish?:
Sets a default value for
$ver
infunc.php
used to avoid browser cache issues. Fixes #2496By submitting this pull request, I confirm the following:
git rebase
)