Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix successful temperature notification #2537

Merged
merged 1 commit into from
Feb 26, 2023
Merged

Fix successful temperature notification #2537

merged 1 commit into from
Feb 26, 2023

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Feb 26, 2023

What does this PR aim to accomplish?:

PR #2516 changes the way how we handle the temperature unit. After setting it via web interface it will show a success message. However, this notification is blue instead of the usual green

Screenshot at 2023-02-26 21-36-48

This PR fixed the color and adds a small success icon.

How does this PR accomplish the above?:

utils.showAlert expects an info type message first and a success/error afterwars. Only if info has been generated, it will change the style to subsequent messages.

https://github.com/pi-hole/AdminLTE/blob/b29a423b9553654f113bcdc8a82296eb6e4613d7/scripts/pi-hole/js/utils.js#L75-L76

This PR adds a info message (it will be barely seen, because it is replaced instantly with the success message).

Screenshot at 2023-02-26 22-17-59


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team February 26, 2023 21:22
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Feb 26, 2023
@rdwebdesign
Copy link
Member

Note:
This PR also fix the error message, setting the alert to red in case of failure.

@yubiuser yubiuser merged commit 4f0c309 into devel Feb 26, 2023
@yubiuser yubiuser deleted the tweak/success branch February 26, 2023 21:56
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-22-web-v5-19-and-core-v5-16-1-released/61999/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants