-
-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply LCARS theme to a few things missing it #2538
Conversation
Could you please provide some screenshots before/after to show the relevant changes? |
Done! |
Thanks for your PR. First, this is a lot about personal taste: I like the new menu with the blue border. However, I see some flickering after opening the menu - is this intended? The teleporter modal with the new black background is hard to distinguish from the rest of the (dark) interface. Could you add a blue border here as well? |
The flickering is intended. It matches the alert messages that pop up. LCARS often has elements that do this and I thought it would be fun to have it there. We can remove it if that's a problem. I'll add the border to the other modal. I'll also check to see if there are some in other locations that can be updated to match. |
OK, I've made the changes. I have determined the borer appears to show on all modals. |
Why did you close the PR? |
Oops |
You changed the background from white to the dark color.
|
Good suggestions. Added, |
Sounds good. I'll try to make that change this weekend. Edit: done. |
Signed-off-by: infinitytec <infinitytec@users.noreply.github.com> Update lcars.css Signed-off-by: infinitytec <infinitytec@users.noreply.github.com> Update lcars.css Signed-off-by: infinitytec <infinitytec@users.noreply.github.com> Update lcars.css Signed-off-by: infinitytec <infinitytec@users.noreply.github.com> Add additional styling for API modal close button Signed-off-by: infinitytec <infinitytec@users.noreply.github.com> Update lcars.css Signed-off-by: infinitytec <infinitytec@users.noreply.github.com> Update lcars.css Signed-off-by: infinitytec <infinitytec@users.noreply.github.com> Update lcars.css Signed-off-by: infinitytec <infinitytec@users.noreply.github.com> Improved borders for modals and fixed header colors Signed-off-by: infinitytec <infinitytec@users.noreply.github.com> Update style/themes/lcars.css Signed-off-by: infinitytec <infinitytec@users.noreply.github.com> Update style/themes/lcars.css Signed-off-by: infinitytec <infinitytec@users.noreply.github.com> Update lcars.css Signed-off-by: infinitytec <infinitytec@users.noreply.github.com> Adjusted theme a bit more Signed-off-by: infinitytec <infinitytec@users.noreply.github.com> Update lcars.css Signed-off-by: infinitytec <infinitytec@users.noreply.github.com> Update lcars.css Signed-off-by: infinitytec <infinitytec@users.noreply.github.com> Co-Authored-By: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: infinitytec <infinitytec@users.noreply.github.com>
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
More fixes to the LCARS theme. This styles the "about" hamburger menu on the upper right and modals such as the Teleporter import.
How does this PR accomplish the above?:
This makes a few changes to style some previously unstyled popups.
Before:
After:
Link documentation PRs if any are needed to support this PR:
n/a
By submitting this pull request, I confirm the following:
git rebase
)