Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NaN error message when FTL is offline or Web interface session expired #2548

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented Mar 17, 2023

What does this PR aim to accomplish?

Since commit b7c0fcb1 the function formats the numbers to respect locale differences and round to one decimal place.

The problem is the function is trying to format the output even when FTL is offline and the values are not numbers.
This shows NaN error on the boxes:

image

How does this PR accomplish the above?

Only formating the values if FTL is online.

The fixed output will show the expected message:

image

Link documentation PRs if any are needed to support this PR:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign merged commit 6de61a1 into devel Mar 22, 2023
@rdwebdesign rdwebdesign deleted the fix_NaN branch March 22, 2023 20:32
@rdwebdesign rdwebdesign changed the title Fix NaN error message when FTL is offline Fix NaN error message when FTL is offline or Web interface session expired Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants