Fix HttpWebRequest proxy test (dotnet/corefx#36191)

Change test so that it doesn't trip up CredScan. Fixes dotnet/corefx#36187 Commit migrated from dotnet/corefx@d09d8f7
picenka21 · Mar 20, 2019 · 7396d92 · 7396d92
1 parent f094cb0
commit 7396d92
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs b/src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs
@@ -1321,10 +1321,9 @@ public void Proxy_GetDefault_ExpectNotNull(Uri remoteServer)
         [Fact]
         public async Task ProxySetViaEnvironmentVariable_DefaultProxyCredentialsUsed()
         {
-            const string ExpectedUsername = "rightusername";
-            const string ExpectedPassword = "rightpassword";
+            var cred = new NetworkCredential(Guid.NewGuid().ToString("N"), Guid.NewGuid().ToString("N"));
             LoopbackServer.Options options =
-                new LoopbackServer.Options { IsProxy = true, Username = ExpectedUsername, Password = ExpectedPassword };
+                new LoopbackServer.Options { IsProxy = true, Username = cred.UserName, Password = cred.Password };
 
             await LoopbackServer.CreateServerAsync(async (proxyServer, proxyUri) =>
             {
@@ -1337,9 +1336,9 @@ await LoopbackServer.CreateServerAsync(async (proxyServer, proxyUri) =>
                 proxyTask = proxyServer.AcceptConnectionPerformAuthenticationAndCloseAsync("Proxy-Authenticate: Basic realm=\"NetCore\"\r\n");
                 psi.Environment.Add("http_proxy", $"http://{proxyUri.Host}:{proxyUri.Port}");
 
-                RemoteInvoke(async () =>
+                RemoteInvoke(async (user, pw) =>
                 {
-                    WebRequest.DefaultWebProxy.Credentials = new NetworkCredential(ExpectedUsername, ExpectedPassword);
+                    WebRequest.DefaultWebProxy.Credentials = new NetworkCredential(user, pw);
                     HttpWebRequest request = HttpWebRequest.CreateHttp(Configuration.Http.RemoteEchoServer);
 
                     using (var response = (HttpWebResponse) await request.GetResponseAsync())
@@ -1348,7 +1347,7 @@ await LoopbackServer.CreateServerAsync(async (proxyServer, proxyUri) =>
                     }
 
                     return SuccessExitCode;
-                }, new RemoteInvokeOptions { StartInfo = psi }).Dispose();
+                }, cred.UserName, cred.Password, new RemoteInvokeOptions { StartInfo = psi }).Dispose();
 
                 await proxyTask;
             }, options);