-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpecFlow conformant name mapping in other test result providers #326
Comments
@danielpullwitt do you think you would have time to take a look at this one? Thanks! |
How urgent is this? I can have a look at this but not immediately during the next few days as i'm very busy and this requires at least to run tests with all the affected frameworks. |
Since I'd prefer to have parity on all unit test frameworks I'd prefer this sooner than later. There is actually an infrastructure in place to help with this, it's described in the CONTRIBUTING.md file. Please let me know if the information there is enough to get you started. If you need more information, I'll happily provide it. |
I probably have time to look at this tomorrow evening to find out how much effort is involved. |
So far I´ve got the test results extended and tests set up and running. In three cases the test is failing (as expected); as soon as I find time I will fix the test providers. |
Excellent, thanks! |
While I could fix the test providers (nunit / xunit / vstest) for scenarios and scenario outlines, I now have problems with cucumber / cucumberjs: Could you provide the missing information? |
Thanks for the heads-up, I'll do my best to provide the information by Monday evening (European time). |
I added the information to the README.md for the pickles-testresults repository. Please let me know if you think I left something out. |
In principle the setup works, but I got a problem with the javascript tests (there are "TypeError: callback.pending is not a function" messages). As I'm not deep into javascript development, I opted for manually editing the resulting json file and got everything else working. This is a little bit unsatisfactory but I have no clear idea about the nature of the actual problem. |
I'm not a javascript expert myself, but if you push your code to GitHub I will take a look at it and try to help you. Or are the errors happening with the code that is already there? |
They occur in the existing code, I also get a slightly different json output (more 'match' information), I don't know if its due to a different cucumber version or any other version / system dependent behavior |
I just found on the cucumber-js page that for not implemented tests you now use |
Yes, please fix that - that's very kind of you! |
Done, pull requests for test data and main pickles repository are available |
Thank you again! |
Released in version 2.6.1. |
No description provided.
The text was updated successfully, but these errors were encountered: