Unsubscribe from the input event handler #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Class: 'Binding', method: 'RemovePropertyEvent'. If we don't do that, dotMemory (and probably other memory profiling tools) will report about an event leakage of 'PropertyNotifyHelper'. At the moment, nothing is done with the EventHandler<EventArgs>, that is passed as an input parameter. Performing the change fixes the report of the memory profiling tool.
|
Hey @Dmitri-Kom, thanks so much for the PR! This looks great, thanks for catching that leak. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class:
Binding, method:RemovePropertyEvent.If we don't do that,
dotMemory(and probably othermemory profiling tools) will report about an event
leakage of
PropertyNotifyHelper.At the moment, nothing is done with the
EventHandler, that is passed as an
input parameter to the
RemovePropertyEventmethod.Performing the change fixes the report of the memory
profiling tool.