Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac: Fix regression with Drawable clipping #2558

Merged

Conversation

cwensley
Copy link
Member

@cwensley cwensley commented Oct 6, 2023

We were using the flipped dirty rect to clip to when it was expecting a non-flipped rect. Now we clip to the dirty rect first then flip so we get the right coordinates in PaintEventArgs.ClipRectangle.

@cwensley cwensley added the bug label Oct 6, 2023
@cwensley cwensley added this to the 2.8.1 milestone Oct 6, 2023
@cwensley cwensley merged commit 12c0a04 into picoe:develop Oct 6, 2023
3 checks passed
@cwensley cwensley deleted the curtis/mac-fix-drawable-clipping-again branch October 6, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant