Unsaved indicator for DocumentControl #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce `ImageRect` and `UsavedRect`; - Calculate rectangles once in `CalculateTab` (except for `closeForegroundRect` which is calculated while drawing it); - Restructure calculations element by element; - Each of the element has valid location and size (even though it can be empty); - (Hopefully) simplify calculations by using `PointF` and `RectangleF` methods; - Simplify drawing of the close button.
|
Looks great, @ievgen-baida! Thanks for the contribution. |
ievgen-baida
changed the title
ievgen-baida
deleted the
feature/unsaved-indictator-for-document-control
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds possibility to mark individual document page as one having unsaved changes (
HasUnsavedChanges). Such page would then be rendered with a little round indicator after the name of the document. The color can be configured usingUnsavedBackgroundColorproperty.Also, the calculations and drawing for each tab in
ThemedDocumentControlHandlerhave been refactored:ImageRectandUsavedRect;CalculateTab(except forcloseForegroundRectwhich is calculated while drawing it);empty);
PointFandRectangleFmethods;