Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requesting PIDs for Solo1 fork #886

Closed
wants to merge 2 commits into from
Closed

Requesting PIDs for Solo1 fork #886

wants to merge 2 commits into from

Conversation

sandeepansg
Copy link
Contributor

Requesting PIDs for a fork of Solokey Solo 1

tannewt
tannewt requested changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your repo doesn't actually have any changes from upstream except changing the PID. Please use a test pid until you actually have a functional difference.

@tannewt tannewt closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandeepansg @tannewt