This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
Adding the ability to set up Automated Builds #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We built a module that depends on this lz4 module, but due to the utilities used by our consumers several do not easily have access to install
windows-build-tools
and build the package themselves locally. As a result, it makes more sense to publish pre-built binaries (as referred to in #67, I work with Mike who posted that issue).In here I've added an appveyor.yml file which can be used to set up an appveyor job that pre-builds windows versions of the library, and set up the package.json to utilize
node-pre-gyp
to check and download assets from releases in github.I've also updated the usage of the lz4 library to fix warnings of deprecated functions, and updated a couple of the dependencies. In my testing this works and the resulting tar.gz file is able to be downloaded and installed by
node-pre-gyp
. In order to use this, an appveyor.yml project would need to be created and connected to this repo, along with putting a github token (encrypted via appveyor similar to the way travis works) into the yml file in order to allow it to deploy and publish the binaries. Would these be things you'd be willing to do after merging this?I've also condensed the compiled binary into a single lz4.node file since that was easier for specifying the artifacts and telling node-pre-gyp how to package things.