Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The S3 credentials can be provided directly or in the environment. Fully composable and works excellently with the groupcache implementation. Admittedly plays loose with contexts. Resolves #26
In the groupcache example, swapping out
testdata
and updatingnewServer()
, while taking a new CLI argument forawsS3bucket
works perfectly. If the S3 path would bes3://somebucket/food/20200809_0030_01.jpg
thenhttp://localhost:8081/food/20200809_0030_01.jpg?&width=1024
would be example path. I can provide a full example if desirable. Happy to iterate on this for a while too if there is feedback.