switch to US017 in reporting functions

[fbenke-pik]

No description provided.

[orichters]

I have no strong opinion on this, but IIASA changes all units to USD_2017, not US$2017, mainly because they realized the $ sign created problems in some scripts, as far as I understood. We might use that as an opportunity to do that as well. piamInterfaces will handle both cases without a problem, so this shouldn't affect our decision.

[fbenke-pik]

@LaviniaBaumstark What do you think?

[orichters]

What about

• https://github.com/fbenke-pik/remind2/blob/update_2024/vignettes/remind_summary.Rmd
• https://github.com/fbenke-pik/remind2/blob/update_2024/R/calcNetTradeValue.R#L11

By the way: What is the purpose of these calc… functions? Is anyone using them at all?

[orichters]

Looks good apart from these two tiny comments. Thanks for implementing that!

[fbenke-pik]

What about

* https://github.com/fbenke-pik/remind2/blob/update_2024/vignettes/remind_summary.Rmd

* https://github.com/fbenke-pik/remind2/blob/update_2024/R/calcNetTradeValue.R#L11

By the way: What is the purpose of these calc… functions? Is anyone using them at all?

I think we can skip these for now. Not sure if the vignette and calc functions are still used, but we could remove stuff like this as part of a general cleanup of remind2 (there are more artifacts that could be removed).