Clean up reportEmi() and reportFE() functions by removing backward compatibilities #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
August 16, 2024 12:52
…7_plasticsCarbon and vm_demFENonEnergySector, i.e. from before feedstocks implementation
…_IndstCO2Captured
…eDetail, i.e. from before CDR portfolio realization
…ompatibility and read from GDX file again
…entally been removed
…d for non-energy use
…kwards compatibility and read from GDX file again" This reverts commit 80a5a3b. Also adds some more comments in reportEmi().
…enFeNonEnergySector
…ule realization other than 'portfolio'
…t dimension in vm_demFeSector (used for deleted transport complex realization)
fschreyer
requested review from
Renato-Rodrigues,
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q and
fbenke-pik
fbenke-pik
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up two reporting functions by removing if-clauses required for GDX files before REMIND 3.3.0 addressing issue #524.
To see the specific backward compatibilities I removed, please see
the commit list.this list
remove backwards compatability in reportFE for GDX files …fegatdimension invm_demFeSector(used for deleted transport complex realization)portfolioo37_demFeIndSubvm_denFeNonEnergySectorpm_IndstCO2Capturedo37_demFeIndSubvm_incinerationEmiv37_plasticsCarbonandvm_demFENonEnergySector, i.e. from before feedstocks implementationvm_emienFuelExvm_emiCdrTeDetail, i.e. from before CDR portfolio realizationThis is pure code cleaning and I checked for
/p/projects/remind/modeltests/remind/output/SSP2-EU21-PkBudg1050-AMT_2024-08-31_03.27.11that values in the mif-files do not change.Let me know if you have any concerns about the parts I removed.