Add P2300 reference implementation #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
force-pushed
the
add-p2300-reference-implementation
branch
2 times, most recently
from
e86b77f to
0e40301
Compare
msimberg
force-pushed
the
add-p2300-reference-implementation
branch
from
0e40301 to
66d40e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by pika-org/pika#436.
I also slightly cleaned up the changes in #15. I'm now instead installing CMake directly into
/usr/localwithtar's--strip-componentsflag. This avoids having to setPATHfor CMake.Note that I'm not updating the HIP image version since only the location of CMake changed.I also updated the HIP image version because I removed settingCXXtohipcc.