Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation with fmt 10 #686

Closed
msimberg opened this issue May 12, 2023 · 1 comment · Fixed by #691
Closed

Fix compilation with fmt 10 #686

msimberg opened this issue May 12, 2023 · 1 comment · Fixed by #691
Assignees
@msimberg
Labels
category: CUDA category: HIP effort: 2 A few hours of work. priority: medium This should be done sooner or later. type: bug
Milestone
0.16.0

Comments

@msimberg
Copy link
Contributor

It seems like compiling pika with CUDA/HIP enabled now breaks with fmt 10 (e.g. https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/4700071344751697/7514005670787789/-/jobs/4274622344#L6). This seems to be coming from fmt not wanting to format cudaError_t/hipError_t without a formatter. We should investigate why this changed and then fix it in pika (cast to int since that's all the error codes are?).
@msimberg msimberg added effort: 2 A few hours of work. priority: medium This should be done sooner or later. type: bug category: CUDA category: HIP labels May 12, 2023
@msimberg msimberg added this to the 0.16.0 milestone May 12, 2023
@msimberg msimberg mentioned this issue May 12, 2023
Merged
2 tasks
@msimberg msimberg moved this from Backlog to Todo in pika planning board May 15, 2023
@msimberg
Copy link
Contributor Author

msimberg commented May 15, 2023 •
edited
Loading

I think the reason for this is probably (emphasis mine):

Removed deprecated implicit conversions for enums and conversions to primitive types for compatibility with std::format and to prevent potential ODR violations. Use format_as instead.

From https://github.com/fmtlib/fmt/releases/tag/10.0.0.

@msimberg msimberg self-assigned this May 19, 2023
@msimberg msimberg moved this from Todo to In Progress in pika planning board May 19, 2023
@msimberg msimberg mentioned this issue May 22, 2023
Merged
@bors bors bot closed this as completed in ea25cf7 May 23, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in pika planning board May 23, 2023
@msimberg msimberg moved this from Done to Archive in pika planning board Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msimberg msimberg

Labels
category: CUDA category: HIP effort: 2 A few hours of work. priority: medium This should be done sooner or later. type: bug
Projects
pika planning board
Archived in project
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Allow compilation with fmt 10 with CUDA/HIP msimberg/pika
1 participant
@msimberg