Use async_rw_mutex in Pipeline
#859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
commented
May 8, 2023
msimberg
changed the title
async_rw_mutex in PIpelineasync_rw_mutex in Pipeline
msimberg
force-pushed
the
pipeline-async-rw-mutex
branch
from
b913a65 to
335d835
Compare
|
cscs-ci run |
msimberg
commented
May 11, 2023
|
cscs-ci run |
msimberg
force-pushed
the
pipeline-async-rw-mutex
branch
2 times, most recently
from
d24eb8a to
ba99675
Compare
|
cscs-ci run |
|
cscs-ci run |
|
Note, it seems like fmt 10 breaks pika with CUDA/HIP enabled. I've added a version constraint for now in the CI environments, but we need to work around this in pika itself. Hopefully we'll have that fixed by 0.16.0. pika-org/pika#686 |
|
cscs-ci run |
albestro
approved these changes
May 15, 2023
CommunicatorWrapper alias was removed and replaced by a templated alias in Pipeline. Uses of CommuncatorWrapper were replaced by Pipeline<Communicator>::Wrapper.
msimberg
force-pushed
the
pipeline-async-rw-mutex
branch
from
518472b to
03a2ae7
Compare
|
Waiting for spack/spack#37679 before retriggering CI. |
|
cscs-ci run |
msimberg
force-pushed
the
pipeline-async-rw-mutex
branch
from
df4d2b7 to
55b65eb
Compare
|
cscs-ci run |
albestro
approved these changes
May 16, 2023
rasolca
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs pika-org/pika#677 so will have to wait again for the next pika release. Please ignore this for now.
Fixes #830.
This follows up #766 by using
async_rw_mutexinPipeline. It only uses thereadwritemode ofasync_rw_mutexto provide sequenced access toCommunicators etc.Open question: Like the rename of
Matrix::operator()toMatrix::readwrite(), do we want to renamePipeline::operator()? I thinkoperator()makes more sense in thePipelinecase than in theMatrixcase since there is only one way to access what's in thePipeline. I'd be happy to leave it asoperator(), but I also think an explicit named member function could make sense. If we name it explicitly, the naming is a bit more difficult than forMatrix.readwrite?access?get(too overloaded in other contexts I think)? Something else?To do:
CMakeLists.txtfmtversion constraint (pika: add conflict withfmt@10when+cuda/rocmspack/spack#37679)