Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI image to use Ubuntu 23.10 as base #1003

Merged
merged 6 commits into from
Jan 31, 2024

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Jan 24, 2024

Updates clang and related tools to version 16, based on ubuntu 23.10.

clang-format 16 introduces some major and some minor formatting changes. The major change is that it seems to change the indentation of multiline macros. I couldn't find a setting to change this back to the previous formatting so these changes we'll have to accept as they are. Additionally, I've chosen some hopefully reasonable values for a few new options in 15 and 16. Interestingly, there is now an option to insert (or remove) separators in integer literals. I've set the configuration to add separators every four digits for binary and hexadecimal literals as I think this makes it much easier to count the positions of the digits. For decimal literals I've set the option to "keep whatever is there". Another alternative would be every three digits but I found this makes some version literals (which are logically grouped by 100s) read a bit weirdly. Happy to change this if you prefer something else. The current option means that we can add separators as we see fit and clang-format won't change it. It's also possible to set it to "always remove separators".

clang-tidy also has some new checks. In the MoodyCamel concurrent queue it warns about bugprone assignment in if statements. I've silenced these. It also has a new check for optional access without a has_value/bool() guard. I've silenced the warning where we assert first that the optional is non-empty. I've also updated a number of accesses to the unchecked operator* since we already check for a value first, instead of using the checking and throwing value().

@msimberg msimberg added this to the 0.23.0 milestone Jan 24, 2024
@msimberg msimberg self-assigned this Jan 24, 2024
@msimberg msimberg force-pushed the update-ci-image-23.10 branch 8 times, most recently from b9e7254 to fd1f55c Compare January 29, 2024 14:54
@msimberg msimberg force-pushed the update-ci-image-23.10 branch from fd1f55c to c0ea994 Compare January 30, 2024 10:23
@msimberg msimberg marked this pull request as ready for review January 30, 2024 10:29
@msimberg
Copy link
Contributor Author

This is ready for review though I would still like to at least briefly see if I can convince clang-format to do something different in context_posix.hpp as it creates very weird indentation in that file right now.

@msimberg msimberg force-pushed the update-ci-image-23.10 branch from c0ea994 to c28eaa5 Compare January 30, 2024 15:32
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link
Contributor

@biddisco biddisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msimberg msimberg force-pushed the update-ci-image-23.10 branch from 58e0216 to 4146252 Compare January 31, 2024 08:40
@msimberg
Copy link
Contributor Author

cscs-ci run ci-on-merge

@msimberg msimberg enabled auto-merge January 31, 2024 08:41
@msimberg msimberg added this pull request to the merge queue Jan 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2024
@msimberg msimberg added this pull request to the merge queue Jan 31, 2024
Merged via the queue into pika-org:main with commit ad968e0 Jan 31, 2024
53 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

3 participants