-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI image to use Ubuntu 23.10 as base #1003
Conversation
b9e7254
to
fd1f55c
Compare
fd1f55c
to
c0ea994
Compare
libs/pika/coroutines/include/pika/coroutines/detail/context_posix.hpp
Outdated
Show resolved
Hide resolved
This is ready for review though I would still like to at least briefly see if I can convince clang-format to do something different in |
c0ea994
to
c28eaa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
58e0216
to
4146252
Compare
cscs-ci run ci-on-merge |
Updates clang and related tools to version 16, based on ubuntu 23.10.
clang-format 16 introduces some major and some minor formatting changes. The major change is that it seems to change the indentation of multiline macros. I couldn't find a setting to change this back to the previous formatting so these changes we'll have to accept as they are. Additionally, I've chosen some hopefully reasonable values for a few new options in 15 and 16. Interestingly, there is now an option to insert (or remove) separators in integer literals. I've set the configuration to add separators every four digits for binary and hexadecimal literals as I think this makes it much easier to count the positions of the digits. For decimal literals I've set the option to "keep whatever is there". Another alternative would be every three digits but I found this makes some version literals (which are logically grouped by 100s) read a bit weirdly. Happy to change this if you prefer something else. The current option means that we can add separators as we see fit and clang-format won't change it. It's also possible to set it to "always remove separators".
clang-tidy also has some new checks. In the MoodyCamel concurrent queue it warns about bugprone assignment in
if
statements. I've silenced these. It also has a new check for optional access without ahas_value/bool()
guard. I've silenced the warning where we assert first that the optional is non-empty. I've also updated a number of accesses to the uncheckedoperator*
since we already check for a value first, instead of using the checking and throwingvalue()
.