Fix setting of global thread number #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
force-pushed
the
fix-global-thread-num-tss
branch
from
f94b8e1 to
104e891
Compare
Refactor thread manager callbacks to use more verbose, but more explicit lambdas for the callbacks. The on_start_thread callback was passing the local instead of the global thread number to init_tss.
msimberg
force-pushed
the
fix-global-thread-num-tss
branch
from
104e891 to
a172190
Compare
Merged
aurianer
reviewed
Feb 6, 2024
|
sorry I realized I hadn't posted my review, it's anyway not a so important comment :) |
msimberg
added a commit
that referenced
this pull request
Feb 7, 2024
Fix setting of global thread number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (thread-pool-)local thread number was being set as the global thread number. When using only one thread pool this has no impact since the local and global numbers are the same. When using multiple pools (e.g. an MPI pool) the global thread number will be wrong on all but one pool. This is especially problematic if using the global thread number to index into data structures, like in #872.
This adds a test that checks that the pool and the local/global thread numbers are correct one every pool, when creating one pool for each PU.
This also changes the callbacks in the thread manager to use more explicit lambdas instead of
bindwith placeholders. This is where the wrong number was being passed toinit_tss.