Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faster invoke_result for cases where we know we're not dealing with member functions #1060

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

msimberg
Copy link
Contributor

In the spirit of #1058, add a invoke_result_plain_function type trait for use in cases where we know that the function is not a member function and we don't need the full std::invoke_resutl. This is true at least in cases where we're checking if a CPO is invocable. More generic cases where the callable comes from the user continue to use std::invoke_result.

@msimberg msimberg self-assigned this Mar 13, 2024
@msimberg msimberg added this to the 0.24.0 milestone Mar 13, 2024
@msimberg msimberg force-pushed the faster-invoke-result branch from 99296c3 to 7c4f8bb Compare March 13, 2024 12:49
@msimberg msimberg force-pushed the faster-invoke-result branch from 7c4f8bb to 1fbce0e Compare March 19, 2024 16:35
@msimberg msimberg enabled auto-merge March 19, 2024 16:35
@msimberg msimberg added this pull request to the merge queue Mar 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 20, 2024
@msimberg msimberg added this pull request to the merge queue Mar 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 20, 2024
@msimberg msimberg added this pull request to the merge queue Mar 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2024
@msimberg msimberg added this pull request to the merge queue Mar 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2024
@msimberg msimberg added this pull request to the merge queue Mar 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2024
@msimberg msimberg added this pull request to the merge queue Mar 21, 2024
@msimberg
Copy link
Contributor Author

Merging manually. All important CI configurations finished successfully, and the NVHPC configuration is taking too long.

@msimberg msimberg removed this pull request from the merge queue due to a manual request Mar 21, 2024
@msimberg msimberg merged commit 13546f7 into pika-org:main Mar 21, 2024
37 of 38 checks passed
@msimberg msimberg deleted the faster-invoke-result branch March 21, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

1 participant