Fix builds with newest stdexec #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
commented
Apr 24, 2024
msimberg
force-pushed
the
stdexec-sender-concept-fixes
branch
3 times, most recently
from
2d67b72 to
1d4f37d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
msimberg
force-pushed
the
stdexec-sender-concept-fixes
branch
from
1d4f37d to
378cb43
Compare
Performance test reportpika PerformanceComparison
Info
Explanation of Symbols
|
msimberg
commented
Apr 30, 2024
msimberg
force-pushed
the
stdexec-sender-concept-fixes
branch
2 times, most recently
from
6accc07 to
7c18530
Compare
Performance test reportpika PerformanceComparison
Info
Explanation of Symbols
|
…d_pool_scheduler The bulk callable expects an extra argument that was not being sent from the predecessor then sender since the then callable returns void. This adds a return to the then callable. Newer versions of stdexec diagnose this issue without connecting a receiver.
Actually return a sender from callable, and send error to let_error.
MPI, precompiled headers, and stdexec seem to conflict, leading to duplicate mangled symbols:
/usr/local/include/stdexec/__detail/__env.hpp:310:9: error: definition with same mangled name '_ZNK7stdexec5__env9get_env_tclINS_7__sexprIXtlNS_12_GLOBAL__N_1UlvE7_EEENS4_6__anonEEEEEDTcl10tag_invokeclL_ZNS_9__declvalIS1_EEOT_vEEcl9__declvalIRKS9_EEEESC
_' as another definition
operator()(const _EnvProvider& __env_provider) const noexcept
^
/usr/local/include/stdexec/__detail/__env.hpp:310:9: note: previous definition is here
Since precompiled headers don't change functionality, this disables them, rather than disabling MPI
or stdexec in CI.
msimberg
force-pushed
the
stdexec-sender-concept-fixes
branch
from
7c18530 to
014f808
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…nv specialization nvc++ is not able to compile the function using constexpr. Since get_env isn't typically required at constexpr-time, simply remove the constexpr.
msimberg
force-pushed
the
stdexec-sender-concept-fixes
branch
from
c27b4f6 to
a9dcd11
Compare
Performance test reportpika PerformanceComparison
Info
Explanation of Symbols
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opts in to the newer stdexec sender/receiver concepts (with
using sender_concept = stdexec::sender_tetc.). Also fixes a number of compilation failures resulting from stricter checks etc. in stdexec.