Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor logging fixes #1127

Merged
merged 3 commits into from
May 30, 2024
Merged

Minor logging fixes #1127

merged 3 commits into from
May 30, 2024

Conversation

msimberg
Copy link
Contributor

This fixes some minor issues with the logging output related to hostnames and ranks:

  • The hostname was printed twice in multi-rank runs.
  • The thread and pool indices were printed as hexadecimal which in my opinion doesn't make much sense; they're now printed as decimal.
  • The MPI rank is retrieved with MPI_Comm_rank first, if MPI is initialized.
  • If the MPI rank can't be retrieved with MPI_Comm_rank, the way environment variables are checked is slightly changed to prioritize environment variable names that are more likely to contain the rank.

Mikael Simberg added 3 commits May 24, 2024 16:00
- Change loop order so that environment variable suffixes are tested in
  order against all environment variables. This reordering means that
  the suffixes are given a priority, instead of the previous order which
  gave priority to the first environment variable matching any of the
  suffixes.
- Change the list of suffixes to be more likely to match the world rank,
  rather than a node id or a local rank.
@msimberg msimberg added this to the 0.26.0 milestone May 27, 2024
@msimberg msimberg self-assigned this May 27, 2024
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKRESULT
Task Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Commit0abc0844192aff
pika Datetime2024-02-19T15:15:15+00:002024-05-27T09:12:34+00:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostnamenid00025nid01209
Datetime2024-02-19T16:26:16.072067+01:002024-05-27T11:23:01.786541+02:00
Clusternamedaintdaint
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@msimberg msimberg added this pull request to the merge queue May 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 30, 2024
@msimberg msimberg merged commit a273730 into pika-org:main May 30, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

3 participants