Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shared_mutex #1155

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Remove shared_mutex #1155

merged 1 commit into from
Jun 27, 2024

Conversation

msimberg
Copy link
Contributor

shared_mutex is currently badly maintained, badly tested, and possibly buggy with no pressing need to fix it. Removing it until there is a need for it, hopefully with more extensive testing.

@msimberg msimberg added this to the 0.26.0 milestone Jun 10, 2024
@msimberg msimberg self-assigned this Jun 10, 2024
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@aurianer aurianer enabled auto-merge June 10, 2024 18:29
@msimberg
Copy link
Contributor Author

As this only removes functionality I'm hoping that merging without the full CI will be safe.

@msimberg msimberg disabled auto-merge June 27, 2024 10:43
@msimberg msimberg merged commit 7fbad29 into pika-org:main Jun 27, 2024
36 of 38 checks passed
@msimberg msimberg deleted the remove-shared-mutex branch June 27, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

2 participants