Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with backtraces disabled part 2 #1196

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Jul 4, 2024

#1178 was incomplete. I've rearranged headers a bit so that pika/debugging/backtrace/backtrace.hpp is never included directly. It's not meant for end-users, but it's also not meant for internal use, except for inclusion in pika/debugging/backtrace.hpp. I've move the header to pika/debugging/detail/backtrace.hpp instead. This fixes compilation of the header tests.

@msimberg msimberg added this to the 0.26.0 milestone Jul 4, 2024
@msimberg msimberg self-assigned this Jul 4, 2024
@msimberg msimberg merged commit 50c60c3 into pika-org:main Jul 4, 2024
31 of 35 checks passed
@msimberg msimberg deleted the fix-backtrace-2 branch July 4, 2024 07:37
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.10% (target: -1.00%) (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7896e25) 18541 13853 74.72%
Head commit (f6fd282) 18541 (+0) 13871 (+18) 74.81% (+0.10%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1196) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

1 participant