Use binary_semaphore instead of condition_variable for synchronizing in sync_wait

[msimberg]

Using a binary semaphore removes the need for keeping a mutex and atomic boolean alongside the condition variable. The lock and boolean are effectively moved inside the binary semaphore. As sync_wait is called rarely this is unlikely to actually improve performance, but if nothing else the version with a binary semaphore is noticeably simpler.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.10% (target: -1.00%)	❌ 0.00% (target: 90.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (c799a97)	18376	13737	74.76%
Head commit (e5ff06a)	18376 (+0)	13719 (-18)	74.66% (-0.10%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1206)	1	0	0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

---

_{🚀 Don’t miss a bit, follow what’s new on Codacy.}

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}