Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to FindBoost deprecation with CMake 3.30 #1229

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

aurianer
Copy link
Contributor

Fixes #1222

We require Boost version >= 1.71 in pika, BoostConfig.cmake is available in boost installations since 1.70, so only changing module to config was necessary.

@aurianer aurianer changed the title Adapt to FindBoost deprecation with cmake@3.30 Adapt to FindBoost deprecation with cmake@3.30 Aug 30, 2024
Copy link

codacy-production bot commented Aug 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (89f5337) 18360 13718 74.72%
Head commit (236e3a1) 18358 (-2) 13713 (-5) 74.70% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1229) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll need a newer commit of spack which contains spack/spack#46062, but otherwise this is ok to merge.

Boost header only was only copying files, the boostconfig.cmake
file was not there.
@aurianer aurianer force-pushed the adapt_to_findboost_deprecation branch from 2a9e011 to 644c318 Compare August 30, 2024 14:06
@msimberg msimberg changed the title Adapt to FindBoost deprecation with cmake@3.30 Adapt to FindBoost deprecation with cmake 3.30 Sep 4, 2024
@msimberg msimberg changed the title Adapt to FindBoost deprecation with cmake 3.30 Adapt to FindBoost deprecation with CMake 3.30 Sep 4, 2024
@msimberg msimberg enabled auto-merge September 4, 2024 09:09
@msimberg msimberg added this to the 0.28.0 milestone Sep 4, 2024
@msimberg msimberg added this pull request to the merge queue Sep 4, 2024
@msimberg
Copy link
Contributor

msimberg commented Sep 4, 2024

There seems to be a concretization issue on the nvhpc pipeline with the new spack version: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/479009878135925/5304355110917878/-/jobs/7742931167. I'm going to risk merging this to get the next release out with the assumption that the error is simply some overconstraint in spack and that there's no issue in the pika build with that pipeline once we get it working.

@msimberg msimberg removed this pull request from the merge queue due to a manual request Sep 4, 2024
@msimberg msimberg merged commit 3bc8d72 into pika-org:main Sep 4, 2024
37 checks passed
@msimberg
Copy link
Contributor

msimberg commented Sep 4, 2024

The clang pipeline failure also needs spack/spack#46200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

Update pika_setup_boost.cmake to use Boost's built-in CMake configuration
2 participants