-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to FindBoost
deprecation with CMake 3.30
#1229
Adapt to FindBoost
deprecation with CMake 3.30
#1229
Conversation
FindBoost
deprecation with cmake@3.30
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We'll need a newer commit of spack which contains spack/spack#46062, but otherwise this is ok to merge.
Boost header only was only copying files, the boostconfig.cmake file was not there.
2a9e011
to
644c318
Compare
FindBoost
deprecation with cmake@3.30FindBoost
deprecation with cmake 3.30
FindBoost
deprecation with cmake 3.30FindBoost
deprecation with CMake 3.30
There seems to be a concretization issue on the nvhpc pipeline with the new spack version: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/479009878135925/5304355110917878/-/jobs/7742931167. I'm going to risk merging this to get the next release out with the assumption that the error is simply some overconstraint in spack and that there's no issue in the pika build with that pipeline once we get it working. |
The clang pipeline failure also needs spack/spack#46200. |
Fixes #1222
We require Boost version >= 1.71 in pika,
BoostConfig.cmake
is available in boost installations since 1.70, so only changing module to config was necessary.