Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable SBO in any_sender and friends #1281

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

msimberg
Copy link
Contributor

Attempting to reenable SBO without any UB, but this needs more testing. We disabled SBO in the past because it was causing issues at least on LUMI, and I haven't re-tested it with these changes yet.

Based on #1280.

@msimberg msimberg self-assigned this Oct 23, 2024
Copy link

codacy-production bot commented Oct 23, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 90.91% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (04d79b2) 18217 13761 75.54%
Head commit (818c420) 18217 (+0) 13764 (+3) 75.56% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1281) 11 10 90.91%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@msimberg msimberg force-pushed the any-sender-sbo-reenable branch from 7d434fe to 818c420 Compare December 19, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant