Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress hwloc_topology_load leak reported by valgrind #1282

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

msimberg
Copy link
Contributor

Suppresses warnings like:

==3585== 
==3585== HEAP SUMMARY:
==3585==     in use at exit: 150,459 bytes in 456 blocks
==3585==   total heap usage: 25,548 allocs, 25,092 frees, 5,775,479 bytes allocated
==3585== 
==3585== 24 bytes in 1 blocks are possibly lost in loss record 94 of 266
==3585==    at 0x4845828: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==3585==    by 0x4C46D29: hwloc_bitmap_dup (in /usr/lib/x86_64-linux-gnu/libhwloc.so.15.6.3)
==3585==    by 0x4C3DAE7: ??? (in /usr/lib/x86_64-linux-gnu/libhwloc.so.15.6.3)
==3585==    by 0x4C3DA75: ??? (in /usr/lib/x86_64-linux-gnu/libhwloc.so.15.6.3)
==3585==    by 0x4C3DA75: ??? (in /usr/lib/x86_64-linux-gnu/libhwloc.so.15.6.3)
==3585==    by 0x4C3DA75: ??? (in /usr/lib/x86_64-linux-gnu/libhwloc.so.15.6.3)
==3585==    by 0x4C3DA75: ??? (in /usr/lib/x86_64-linux-gnu/libhwloc.so.15.6.3)
==3585==    by 0x4C3DA75: ??? (in /usr/lib/x86_64-linux-gnu/libhwloc.so.15.6.3)
==3585==    by 0x4C41F52: hwloc_topology_load (in /usr/lib/x86_64-linux-gnu/libhwloc.so.15.6.3)
==3585==    by 0x7932C58: ???
==3585==    by 0x795788B: ???
==3585==    by 0x78E2802: ???
==3585== 
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   match-leak-kinds: possible
   fun:malloc
   fun:hwloc_bitmap_dup
   obj:/usr/lib/x86_64-linux-gnu/libhwloc.so.15.6.3
   obj:/usr/lib/x86_64-linux-gnu/libhwloc.so.15.6.3
   obj:/usr/lib/x86_64-linux-gnu/libhwloc.so.15.6.3
   obj:/usr/lib/x86_64-linux-gnu/libhwloc.so.15.6.3
   obj:/usr/lib/x86_64-linux-gnu/libhwloc.so.15.6.3
   obj:/usr/lib/x86_64-linux-gnu/libhwloc.so.15.6.3
   fun:hwloc_topology_load
   obj:*
   obj:*
   obj:*
}

I've only seen this triggered on the MPI tests, so I'm assuming this is coming from inside OpenMPI and not our hwloc usage.

@msimberg msimberg self-assigned this Oct 23, 2024
@msimberg msimberg added this to the 0.30.0 milestone Oct 23, 2024
@msimberg msimberg changed the title Suppress hwloc_topology_load leak reported by valgrind Suppress hwloc_topology_load leak reported by valgrind Oct 23, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.07% (target: -1.00%) (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (55bcd72) 18260 13784 75.49%
Head commit (4412f09) 18260 (+0) 13797 (+13) 75.56% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1282) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@msimberg msimberg merged commit 922a33c into pika-org:main Oct 23, 2024
37 checks passed
@msimberg msimberg deleted the hwloc-mpi-valgrind-suppress branch October 23, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

1 participant