Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable clang-tidy checks on CSCS CI clang pipelines #1345

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Nov 20, 2024

Enabling on the clang/CUDA pipeline and the latest clang (19 at the time of the PR) pipeline.

@msimberg msimberg self-assigned this Nov 20, 2024
Copy link

codacy-production bot commented Nov 20, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (49de319) 18212 13746 75.48%
Head commit (cb42304) 18212 (+0) 13749 (+3) 75.49% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1345) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@msimberg msimberg marked this pull request as ready for review November 29, 2024 16:59
@msimberg msimberg requested review from aurianer and removed request for aurianer December 9, 2024 10:34
@msimberg
Copy link
Contributor Author

msimberg commented Dec 9, 2024

This is now ready for review. Ideas for a cleaner way of exposing clang-tidy to the build environment are welcome.

@msimberg msimberg added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 10, 2024
@aurianer aurianer added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 11, 2024
@msimberg msimberg merged commit 7f1242a into pika-org:main Dec 11, 2024
40 checks passed
@msimberg msimberg deleted the clang-tidy-cscs-ci branch December 11, 2024 08:40
@msimberg msimberg added this to the 0.31.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

2 participants