Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separators between parts of API documentation #1384

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

msimberg
Copy link
Contributor

This adds horizontal lines as separators between examples, functions, classes in the API documentation. Especially in cases where e.g. an example, variable, and versionadded directive are grouped together, it can sometimes be hard to see how they are grouped. It's easy to mistake that the example might belong to the next item.

This also moves the async_rw_mutex example up to the top of the section, before the API documentation. This way it serves as an overview before the details of the API documentation. We do the same in the pika/init.hpp section.

@msimberg msimberg self-assigned this Dec 20, 2024
@msimberg
Copy link
Contributor Author

The current documentation looks like this:
2024-12-19-173112_893x1039_scrot

With the separator it looks like this:
2024-12-19-173040_889x1087_scrot

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (aa6ef39) 18217 13769 75.58%
Head commit (a13f619) 18217 (+0) 13766 (-3) 75.57% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1384) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@msimberg msimberg added this to the 0.32.0 milestone Dec 20, 2024
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It improves readability quite much, thanks!

@aurianer aurianer enabled auto-merge December 20, 2024 16:44
@aurianer aurianer added this pull request to the merge queue Dec 20, 2024
Merged via the queue into pika-org:main with commit 65921d2 Dec 20, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants