Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable glibc's tcache temporarily in CircleCI #280

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Disable glibc's tcache temporarily in CircleCI #280

merged 1 commit into from
Jun 30, 2022

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Jun 30, 2022 •
edited
Loading

Temporarily testing to see if disabling glibc's tcache would reduce the error rate on the std_thread_scheduler test (see #250 (comment)). Cf. #281.

@msimberg msimberg added this to the 0.6.0 milestone Jun 30, 2022
@msimberg msimberg mentioned this pull request Jun 30, 2022
Closed
@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jun 30, 2022
@bors
Try #280:
4245b17
@msimberg msimberg self-assigned this Jun 30, 2022
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)++

Info

PropertyBeforeAfter
pika Datetime2021-12-21T15:01:46+00:002022-06-30T07:53:19+00:00
pika Commit01e4980e2184ca113b853ae3a36869f713fcc4b9237e13c
Clusternamedaintdaint
Datetime2021-12-21T16:09:15.238666+01:002022-06-30T10:01:38.286025+02:00
Envfile
Compiler/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostnamenid00932nid00393

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch+++

Info

PropertyBeforeAfter
pika Datetime2021-12-10T13:50:04+00:002022-06-30T07:53:19+00:00
pika Commitf499a2233385060b8a2612ab88163e62b0881888237e13c
Clusternamedaintdaint
Datetime2021-12-10T15:19:42.442217+01:002022-06-30T10:01:53.139634+02:00
Envfile
Compiler/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostnamenid00243nid00393

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
Stream Benchmark - Add(=)=(=)
Stream Benchmark - Scale-------
Stream Benchmark - Triad(=)-(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
pika Datetime2021-11-12T11:29:27+00:002022-06-30T07:53:19+00:00
pika Commitf64fbd02165a132a6276cedd14c586910abb79e4237e13c
Clusternamedaintdaint
Datetime2021-11-12T12:57:50.824026+01:002022-06-30T10:02:08.011630+02:00
Envfile
Compiler/apps/daint/SSL/pika/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostnamenid00007nid00393

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@bors
Copy link
Contributor

bors bot commented Jun 30, 2022

try

Build succeeded:

@msimberg
Copy link
Contributor Author

I'm just going to give this a try. This can easily be reverted.

@msimberg
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 30, 2022

Build succeeded:

@bors bors bot merged commit e43a4a7 into pika-org:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer Awaiting requested review from aurianer aurianer is a code owner

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@msimberg @pika-bot