Allow making CMake options dependent on others #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
Performance test reportpika PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
msimberg
force-pushed
the
cmake-dependent-options
branch
from
9e4a8c5 to
c82f8c9
Compare
Performance test reportpika PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
tryTimed out. |
|
bors try |
tryBuild failed: |
|
bors try |
aurianer
approved these changes
Aug 17, 2022
| option("${option}" "${description}" "${default}") | ||
| else() | ||
| cmake_dependent_option( | ||
| "${option}" "${description}" "${default}" "${PIKA_OPTION_DEPENDS}" OFF |
There was a problem hiding this comment.
Why don't we set the default to ON here? It should be ON if the PIKA_OPTION_DEPENDS is ON right?
There was a problem hiding this comment.
We set the default to default. The last OFF is the <force> variable from https://cmake.org/cmake/help/latest/module/CMakeDependentOption.html?highlight=cmake_dependent_option#command:cmake_dependent_option:
Makes <option> available to the user if the [semicolon-separated list](https://cmake.org/cmake/help/latest/manual/cmake-language.7.html#cmake-language-lists) of conditions in <depends> are all true. Otherwise, a local variable named <option> is set to <force>.
i.e. it's the value that is set if the PIKA_OPTION_DEPENDS condition is not true, which in all cases we have so far should just turn off the option. In theory there could be options that want the inverse, but I think we can add that when we need it.
msimberg
force-pushed
the
cmake-dependent-options
branch
from
c82f8c9 to
d5cbaa4
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Aug 18, 2022
356: Allow making CMake options dependent on others r=msimberg a=msimberg Fixes #317. Also makes the `PIKA_WITH_TESTS_*` and `PIKA_WITH_EXAMPLES_*` options dependent on `PIKA_WITH_TESTS` and `PIKA_WITH_EXAMPLES`, respectively. If someone spots a possibility to use dependent options elsewhere don't hesitate to just change it. I've kept the old `pika_option` implementation for non-`BOOL` types, and added new variants based on `option` and `cmake_dependent_option`. The `pika_option` function is now a macro because of the scope required for the "hidden" (helper) variables used by `cmake_dependent_option`. Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
|
Build failed: |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Aug 18, 2022
356: Allow making CMake options dependent on others r=msimberg a=msimberg Fixes #317. Also makes the `PIKA_WITH_TESTS_*` and `PIKA_WITH_EXAMPLES_*` options dependent on `PIKA_WITH_TESTS` and `PIKA_WITH_EXAMPLES`, respectively. If someone spots a possibility to use dependent options elsewhere don't hesitate to just change it. I've kept the old `pika_option` implementation for non-`BOOL` types, and added new variants based on `option` and `cmake_dependent_option`. The `pika_option` function is now a macro because of the scope required for the "hidden" (helper) variables used by `cmake_dependent_option`. Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
|
Build failed: |
|
bors merge |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #317.
Also makes the
PIKA_WITH_TESTS_*andPIKA_WITH_EXAMPLES_*options dependent onPIKA_WITH_TESTSandPIKA_WITH_EXAMPLES, respectively. If someone spots a possibility to use dependent options elsewhere don't hesitate to just change it.I've kept the old
pika_optionimplementation for non-BOOLtypes, and added new variants based onoptionandcmake_dependent_option. Thepika_optionfunction is now a macro because of the scope required for the "hidden" (helper) variables used bycmake_dependent_option.