Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove parallel_executor_aggregated #372

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Remove parallel_executor_aggregated #372

merged 1 commit into from
Aug 16, 2022

Conversation

msimberg
Copy link
Contributor

No description provided.

@msimberg msimberg added this to the 0.8.0 milestone Aug 11, 2022
@msimberg
Copy link
Contributor Author

bors try

@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
pika Datetime2022-05-17T10:12:00+00:002022-08-11T14:46:49+00:00
pika Commitd45937d9e43038
Envfile
Clusternamedaintdaint
Hostnamenid01398nid01393
Datetime2022-05-17T12:20:04.953138+02:002022-08-11T16:55:33.461810+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Datetime2022-06-24T10:19:16+00:002022-08-11T14:46:49+00:00
pika Commit453f6a49e43038
Envfile
Clusternamedaintdaint
Hostnamenid00025nid01393
Datetime2022-06-24T12:43:43.615347+02:002022-08-11T16:55:48.430896+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale+++-+++
Stream Benchmark - Triad+++++
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
pika Datetime2022-05-17T10:12:00+00:002022-08-11T14:46:49+00:00
pika Commitd45937d9e43038
Envfile
Clusternamedaintdaint
Hostnamenid01398nid01393
Datetime2022-05-17T12:20:34.006375+02:002022-08-11T16:56:03.022399+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

bors bot added a commit that referenced this pull request Aug 11, 2022
@bors
Try #372:
3707ed1
@bors
Copy link
Contributor

bors bot commented Aug 11, 2022

try

Build succeeded:

@msimberg msimberg self-assigned this Aug 12, 2022
aurianer
aurianer approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@aurianer
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 16, 2022

Build succeeded:

@bors bors bot merged commit 37e1f05 into pika-org:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer aurianer approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@msimberg @pika-bot @aurianer