Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up type support #386

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Clean up type support #386

merged 2 commits into from
Aug 22, 2022

Conversation

aurianer
Copy link
Contributor

@aurianer aurianer commented Aug 18, 2022 •
edited
Loading

Part of #16.

  • Delete unused lazy_enable_if.
  • Move functionalities into detail namespace.
  • Rename unwrap_ref to unwrap_reference for C++20 conformance.
  • Rename identity to type_identity for C++20 conformance.

@aurianer aurianer added this to the 0.8.0 milestone Aug 18, 2022
@aurianer
Copy link
Contributor Author

bors try

@aurianer aurianer mentioned this pull request Aug 18, 2022
Open
59 tasks
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
pika Datetime2022-05-17T10:12:00+00:002022-08-18T11:36:19+00:00
pika Commitd45937d17dc561
Envfile
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostnamenid01398nid00238
Datetime2022-05-17T12:20:04.953138+02:002022-08-18T13:45:19.803211+02:00
Clusternamedaintdaint

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch+

Info

PropertyBeforeAfter
pika Datetime2022-06-24T10:19:16+00:002022-08-18T11:36:19+00:00
pika Commit453f6a417dc561
Envfile
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostnamenid00025nid00238
Datetime2022-06-24T12:43:43.615347+02:002022-08-18T13:45:34.368884+02:00
Clusternamedaintdaint

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
Stream Benchmark - Add(=)-(=)
Stream Benchmark - Scale+++(=)+++
Stream Benchmark - Triad+++(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
pika Datetime2022-05-17T10:12:00+00:002022-08-18T11:36:19+00:00
pika Commitd45937d17dc561
Envfile
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostnamenid01398nid00238
Datetime2022-05-17T12:20:34.006375+02:002022-08-18T13:45:49.133474+02:00
Clusternamedaintdaint

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

msimberg
msimberg requested changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you can move all the rest into detail as well.

libs/pika/async_combinators/include/pika/async_combinators/wait_all.hpp Outdated Show resolved Hide resolved
libs/pika/functional/include/pika/functional/detail/empty_function.hpp Show resolved Hide resolved
libs/pika/iterator_support/include/pika/iterator_support/boost_iterator_categories.hpp Outdated Show resolved Hide resolved
libs/pika/type_support/include/pika/type_support/equality.hpp Outdated Show resolved Hide resolved
libs/pika/type_support/include/pika/type_support/identity.hpp Outdated Show resolved Hide resolved
libs/pika/type_support/include/pika/type_support/pack.hpp Show resolved Hide resolved
libs/pika/type_support/include/pika/type_support/unwrap_ref.hpp Outdated Show resolved Hide resolved
bors bot added a commit that referenced this pull request Aug 18, 2022
@bors
Try #386:
740164e
@bors
Copy link
Contributor

bors bot commented Aug 18, 2022

try

Build succeeded:

@msimberg
Copy link
Contributor

This has priority over #390 (the two PRs conflict).

@aurianer aurianer force-pushed the clean_up_type_support branch from e6596f6 to 81d8941 Compare August 22, 2022 14:22
@aurianer
Copy link
Contributor Author

This has priority over #390 (the two PRs conflict).

Thanks

@aurianer aurianer force-pushed the clean_up_type_support branch from 81d8941 to 7526716 Compare August 22, 2022 14:25
@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 22, 2022
@bors
Try #386:
e5a9699
@bors
Copy link
Contributor

bors bot commented Aug 22, 2022

try

Build succeeded:

@msimberg
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 22, 2022

👎 Rejected by code reviews

@msimberg
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 22, 2022

Build succeeded:

@bors bors bot merged commit 82131af into pika-org:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@aurianer aurianer

Labels
type: cleanup
Projects
pika planning board
Archived in project
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aurianer @pika-bot @msimberg