Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace typename std::decay by std::decay_t #388

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Replace typename std::decay by std::decay_t #388

merged 2 commits into from
Aug 22, 2022

Conversation

aurianer
Copy link
Contributor

Help with the cleanup

@aurianer aurianer added this to the 0.8.0 milestone Aug 18, 2022
@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 18, 2022
@bors
Try #388:
8aeb5cd
@bors
Copy link
Contributor

bors bot commented Aug 18, 2022

try

Build failed:

msimberg
msimberg approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

Did you do this with a script or manually?

@aurianer
Copy link
Contributor Author

script haha I don't have the patience to do that manually x)

@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 19, 2022
@bors
Try #388:
e30ed5d
@bors
Copy link
Contributor

bors bot commented Aug 19, 2022

try

Build failed:

@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 19, 2022
@bors
Try #388:
ad8ad12
@bors
Copy link
Contributor

bors bot commented Aug 19, 2022

try

Build failed:

@aurianer aurianer force-pushed the decay_t branch 2 times, most recently from 17f0f7e to 9d10701 Compare August 19, 2022 12:38
@aurianer
Copy link
Contributor Author

bors try

@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
pika Commitd45937d7c83cbb
pika Datetime2022-05-17T10:12:00+00:002022-08-19T12:38:44+00:00
Datetime2022-05-17T12:20:04.953138+02:002022-08-19T14:46:55.198558+02:00
Envfile
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostnamenid01398nid00004

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch=

Info

PropertyBeforeAfter
pika Commit453f6a47c83cbb
pika Datetime2022-06-24T10:19:16+00:002022-08-19T12:38:44+00:00
Datetime2022-06-24T12:43:43.615347+02:002022-08-19T14:47:09.872084+02:00
Envfile
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostnamenid00025nid00004

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
Stream Benchmark - Add(=)(=)-
Stream Benchmark - Scale+++(=)++
Stream Benchmark - Triad++++
Stream Benchmark - Copy(=)=(=)

Info

PropertyBeforeAfter
pika Commitd45937d7c83cbb
pika Datetime2022-05-17T10:12:00+00:002022-08-19T12:38:44+00:00
Datetime2022-05-17T12:20:34.006375+02:002022-08-19T14:47:24.659943+02:00
Envfile
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostnamenid01398nid00004

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@pika-org pika-org deleted a comment from bors bot Aug 19, 2022
@pika-org pika-org deleted a comment from bors bot Aug 19, 2022
@aurianer
Copy link
Contributor Author

bors try-

@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 19, 2022
@bors
Try #388:
5ce626e
@bors
Copy link
Contributor

bors bot commented Aug 19, 2022

try

Build succeeded:

@aurianer
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 22, 2022

Build succeeded:

@bors bors bot merged commit 2d7ba4e into pika-org:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@aurianer aurianer

Labels
type: cleanup
Projects
pika planning board
Archived in project
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aurianer @pika-bot @msimberg