Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up util #420

Merged
merged 6 commits into from
Aug 30, 2022
Merged

Clean up util #420

merged 6 commits into from
Aug 30, 2022

Conversation

aurianer
Copy link
Contributor

Part of #16

@aurianer aurianer added this to the 0.8.0 milestone Aug 29, 2022
@aurianer aurianer self-assigned this Aug 29, 2022
@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 29, 2022
@bors
Try #420:
06ac223
@bors
Copy link
Contributor

bors bot commented Aug 29, 2022

try

Build failed:

@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 29, 2022
@bors
Try #420:
b0f52c6
@bors
Copy link
Contributor

bors bot commented Aug 29, 2022

try

Build failed:

@aurianer aurianer marked this pull request as ready for review August 29, 2022 13:50
@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 29, 2022
@bors
Try #420:
5eab31d
@aurianer aurianer mentioned this pull request Aug 29, 2022
Open
59 tasks
msimberg
msimberg approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo the build error.

@aurianer
Copy link
Contributor Author

bors try

@bors
Copy link
Contributor

bors bot commented Aug 29, 2022

try

Already running a review

@msimberg
Copy link
Contributor

bors try-

@msimberg
Copy link
Contributor

bors merge

bors bot added a commit that referenced this pull request Aug 30, 2022
@bors @aurianer
Merge #420
c7ea48e 
420: Clean up util r=msimberg a=aurianer

Part of #16 

Co-authored-by: Auriane R <aurianer@cscs.ch>
@bors
Copy link
Contributor

bors bot commented Aug 30, 2022

Build failed:

@aurianer
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Aug 30, 2022
@bors @aurianer
Merge #420
e9cbcae 
420: Clean up util r=aurianer a=aurianer

Part of #16 

Co-authored-by: Auriane R <aurianer@cscs.ch>
@bors
Copy link
Contributor

bors bot commented Aug 30, 2022

Build failed:

@msimberg
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 30, 2022

Build succeeded:

@bors bors bot merged commit 41e7a6b into pika-org:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@aurianer aurianer

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aurianer @msimberg