Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mimalloc the default allocator #501

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Make mimalloc the default allocator #501

merged 2 commits into from
Nov 3, 2022

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Nov 3, 2022

Fixes #231.

aurianer
aurianer approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@pika-bot
Copy link
Collaborator

pika-bot commented Nov 3, 2022

Performance test report

pika Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
pika Commitd45937d56a5a56
pika Datetime2022-05-17T10:12:00+00:002022-11-03T15:51:22+00:00
Hostnamenid01398nid00230
Clusternamedaintdaint
Datetime2022-05-17T12:20:04.953138+02:002022-11-03T16:59:27.002561+01:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch+

Info

PropertyBeforeAfter
pika Commit190f18956a5a56
pika Datetime2022-09-16T08:18:06+00:002022-11-03T15:51:22+00:00
Hostnamenid00074nid00230
Clusternamedaintdaint
Datetime2022-09-16T10:25:01.976661+02:002022-11-03T16:59:42.044051+01:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
Stream Benchmark - Add(=)-++
Stream Benchmark - Scale+++(=)+++
Stream Benchmark - Triad+++
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
pika Commitd45937d56a5a56
pika Datetime2022-05-17T10:12:00+00:002022-11-03T15:51:22+00:00
Hostnamenid01398nid00230
Clusternamedaintdaint
Datetime2022-05-17T12:20:34.006375+02:002022-11-03T16:59:56.882645+01:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

biddisco
biddisco approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@biddisco biddisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msimberg msimberg force-pushed the default-allocator-mimalloc branch from 9229680 to ad16114 Compare November 3, 2022 16:36
@msimberg
Copy link
Contributor Author

msimberg commented Nov 3, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 3, 2022

Build succeeded:

@bors bors bot merged commit 22f4fe7 into pika-org:main Nov 3, 2022
@msimberg msimberg added this to the 0.11.0 milestone Nov 25, 2022
@msimberg msimberg self-assigned this Nov 25, 2022
@msimberg msimberg mentioned this pull request Jul 28, 2023
Merged
bors bot added a commit that referenced this pull request Jul 28, 2023
@bors @msimberg
Merge #722
fd696fe 
722: Fix mention of default allocator in README.rst r=msimberg a=msimberg

I didn't update the readme as part of #501.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer aurianer approved these changes

@biddisco biddisco biddisco approved these changes

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

Make mimalloc the default allocator?
4 participants
@msimberg @pika-bot @biddisco @aurianer