Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ensure_started sender noncopyable #539

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Make ensure_started sender noncopyable #539

merged 1 commit into from
Dec 12, 2022

Conversation

msimberg
Copy link
Contributor

No description provided.

@msimberg msimberg added this to the 0.12.0 milestone Dec 12, 2022
@msimberg msimberg self-assigned this Dec 12, 2022
@msimberg
Copy link
Contributor Author

bors merge

@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
pika Datetime2022-09-16T08:18:06+00:002022-12-12T15:30:10+00:00
pika Commit190f1895c6bb31
Hostnamenid00074nid01205
Envfile
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Datetime2022-09-16T10:25:01.976661+02:002022-12-12T16:35:25.642164+01:00
Clusternamedaintdaint

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@bors
Copy link
Contributor

bors bot commented Dec 12, 2022

Build succeeded:

@bors bors bot merged commit fbdac7b into pika-org:main Dec 12, 2022
@msimberg msimberg deleted the ensure_started-noncopyable branch December 12, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer Awaiting requested review from aurianer aurianer is a code owner

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@msimberg @pika-bot