Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use pthread_self/GetCurrentThreadId where not needed in logging module #541

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Don't use pthread_self/GetCurrentThreadId where not needed in logging module #541

merged 1 commit into from
Dec 15, 2022

Conversation

msimberg
Copy link
Contributor

To work around problem in #540.

@msimberg
Don't use pthread_self/GetCurrentThreadId where not needed in logging…
3365518 
… module

Use std::this_thread::get_id instead.
@msimberg msimberg added this to the 0.12.0 milestone Dec 14, 2022
@msimberg msimberg self-assigned this Dec 14, 2022
@msimberg msimberg marked this pull request as draft December 14, 2022 15:41
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch---

Info

PropertyBeforeAfter
pika Datetime2022-09-16T08:18:06+00:002022-12-14T15:40:54+00:00
pika Commit190f189e5d48e2
Datetime2022-09-16T10:25:01.976661+02:002022-12-14T16:51:19.263994+01:00
Envfile
Hostnamenid00074nid00247
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg msimberg marked this pull request as ready for review December 14, 2022 16:33
@msimberg
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Dec 14, 2022
@bors @msimberg
Merge #541
fb8c4ab 
541: Don't use `pthread_self`/`GetCurrentThreadId` where not needed in logging module r=msimberg a=msimberg

To work around problem in #540.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bors
Copy link
Contributor

bors bot commented Dec 14, 2022

Build failed:

  • jenkins/cscs-ault/hipcc-release

@msimberg
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Dec 14, 2022
@bors @msimberg
Merge #541
7a744db 
541: Don't use `pthread_self`/`GetCurrentThreadId` where not needed in logging module r=msimberg a=msimberg

To work around problem in #540.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bors
Copy link
Contributor

bors bot commented Dec 14, 2022

Build failed:

@msimberg
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Dec 14, 2022
@bors @msimberg
Merge #541
5ea7187 
541: Don't use `pthread_self`/`GetCurrentThreadId` where not needed in logging module r=msimberg a=msimberg

To work around problem in #540.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bors
Copy link
Contributor

bors bot commented Dec 14, 2022

Build failed:

@msimberg
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Dec 14, 2022
@bors @msimberg
Merge #541
7362ccc 
541: Don't use `pthread_self`/`GetCurrentThreadId` where not needed in logging module r=msimberg a=msimberg

To work around problem in #540.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bors
Copy link
Contributor

bors bot commented Dec 14, 2022

Build failed:

@msimberg
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Dec 14, 2022
@bors @msimberg
Merge #541
96ea738 
541: Don't use `pthread_self`/`GetCurrentThreadId` where not needed in logging module r=msimberg a=msimberg

To work around problem in #540.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bors
Copy link
Contributor

bors bot commented Dec 14, 2022

Build failed:

@msimberg
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Dec 14, 2022
@bors @msimberg
Merge #541
4907b7f 
541: Don't use `pthread_self`/`GetCurrentThreadId` where not needed in logging module r=msimberg a=msimberg

To work around problem in #540.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bors
Copy link
Contributor

bors bot commented Dec 14, 2022

Build failed:

@msimberg
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 15, 2022

Build succeeded:

@bors bors bot merged commit 4ae7835 into pika-org:main Dec 15, 2022
@msimberg msimberg deleted the fmt-thread-id-workaround branch December 19, 2022 09:06
@msimberg msimberg mentioned this pull request Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer Awaiting requested review from aurianer aurianer is a code owner

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@msimberg @pika-bot