Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bool conversion operator and empty member function to (unique_)any_sender #551

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Add bool conversion operator and empty member function to (unique_)any_sender #551

merged 1 commit into from
Jan 9, 2023

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Jan 5, 2023

Fixes #547.

@msimberg msimberg added this to the 0.12.0 milestone Jan 5, 2023
@msimberg msimberg self-assigned this Jan 5, 2023
@msimberg
Copy link
Contributor Author

msimberg commented Jan 5, 2023

bors try

bors bot added a commit that referenced this pull request Jan 5, 2023
@bors
Try #551:
e8b6fad
@bors
Copy link
Contributor

bors bot commented Jan 5, 2023

try

Build failed:

@pika-bot
Copy link
Collaborator

pika-bot commented Jan 5, 2023

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
pika Commit190f189373a8d7
pika Datetime2022-09-16T08:18:06+00:002023-01-05T13:00:45+00:00
Hostnamenid00074nid01617
Envfile
Datetime2022-09-16T10:25:01.976661+02:002023-01-05T14:15:14.992590+01:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clusternamedaintdaint

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg
Copy link
Contributor Author

msimberg commented Jan 5, 2023

bors try

bors bot added a commit that referenced this pull request Jan 5, 2023
@bors
Try #551:
ba67135
@pika-bot
Copy link
Collaborator

pika-bot commented Jan 5, 2023

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
pika Commit190f18948d3298
pika Datetime2022-09-16T08:18:06+00:002023-01-05T15:26:55+00:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clusternamedaintdaint
Hostnamenid00074nid01193
Envfile
Datetime2022-09-16T10:25:01.976661+02:002023-01-05T16:37:07.027273+01:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@bors
Copy link
Contributor

bors bot commented Jan 5, 2023

try

Build succeeded:

aurianer
aurianer approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@aurianer
Copy link
Contributor

aurianer commented Jan 9, 2023

bors merge

bors bot added a commit that referenced this pull request Jan 9, 2023
@bors @msimberg
Merge #551
53d753f 
551: Add `bool` conversion operator and `empty` member function to `(unique_)any_sender` r=aurianer a=msimberg

Fixes #547.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bors
Copy link
Contributor

bors bot commented Jan 9, 2023

Build failed:

@msimberg
Copy link
Contributor Author

msimberg commented Jan 9, 2023

bors merge

bors bot added a commit that referenced this pull request Jan 9, 2023
@bors @msimberg
Merge #551 #553
ef9862f 
551: Add `bool` conversion operator and `empty` member function to `(unique_)any_sender` r=msimberg a=msimberg

Fixes #547.

553: Bump checkout CI action to v3 r=msimberg a=msimberg



Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bors
Copy link
Contributor

bors bot commented Jan 9, 2023

Build failed (retrying...):

bors bot added a commit that referenced this pull request Jan 9, 2023
@bors @msimberg @aurianer
Merge #551 #554
2bee9d8 
551: Add `bool` conversion operator and `empty` member function to `(unique_)any_sender` r=msimberg a=msimberg

Fixes #547.

554: Fix ault CI by adding `amdgpu_target` explicitly to the spack spec r=msimberg a=aurianer

Add amdgpu_target for pika and whip (now required after spack update)

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
Co-authored-by: aurianer <aurianer@cscs.ch>
@bors
Copy link
Contributor

bors bot commented Jan 9, 2023

Build failed (retrying...):

  • github/macos/debug

bors bot added a commit that referenced this pull request Jan 9, 2023
@bors @msimberg
Merge #551
98d7e55 
551: Add `bool` conversion operator and `empty` member function to `(unique_)any_sender` r=msimberg a=msimberg

Fixes #547.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@bors
Copy link
Contributor

bors bot commented Jan 9, 2023

Build failed:

@msimberg
Copy link
Contributor Author

msimberg commented Jan 9, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 9, 2023

Build succeeded:

@bors bors bot merged commit efb42ae into pika-org:main Jan 9, 2023
@msimberg msimberg deleted the empty-any-sender branch January 9, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer aurianer approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Add bool conversion operator to any_sender
3 participants
@msimberg @pika-bot @aurianer