Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize HIP early to avoid concurrent initialization #591

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Initialize HIP early to avoid concurrent initialization #591

merged 1 commit into from
Feb 13, 2023

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Feb 8, 2023

Part of #573. Initializes HIP early to avoid problems with concurrent initialization. CUDA does not seem to suffer from problems with concurrent initialization, so this is restricted to HIP only.

@msimberg msimberg added this to the 0.13.0 milestone Feb 8, 2023
@msimberg msimberg self-assigned this Feb 8, 2023
@msimberg
Copy link
Contributor Author

msimberg commented Feb 8, 2023

bors try

@pika-bot
Copy link
Collaborator

pika-bot commented Feb 8, 2023

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
pika Commit190f189a2bfda7
pika Datetime2022-09-16T08:18:06+00:002023-02-08T16:26:25+00:00
Hostnamenid00074nid00025
Envfile
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Datetime2022-09-16T10:25:01.976661+02:002023-02-08T18:26:47.646563+01:00
Clusternamedaintdaint

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

bors bot added a commit that referenced this pull request Feb 8, 2023
@bors
Try #591:
13ed515
@bors
Copy link
Contributor

bors bot commented Feb 8, 2023

try

Build failed:

@msimberg
Copy link
Contributor Author

msimberg commented Feb 9, 2023

bors try

bors bot added a commit that referenced this pull request Feb 9, 2023
@bors
Try #591:
b9e4bc2
@bors
Copy link
Contributor

bors bot commented Feb 9, 2023

try

Build failed:

@pika-bot
Copy link
Collaborator

pika-bot commented Feb 9, 2023

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
pika Datetime2022-09-16T08:18:06+00:002023-02-09T08:20:28+00:00
pika Commit190f1899256c4c
Datetime2022-09-16T10:25:01.976661+02:002023-02-09T09:29:20.891187+01:00
Clusternamedaintdaint
Envfile
Hostnamenid00074nid00004
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

aurianer
aurianer approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Feb 13, 2023
@bors
Try #591:
fa48cea
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch---

Info

PropertyBeforeAfter
pika Commit190f1896ccf838
pika Datetime2022-09-16T08:18:06+00:002023-02-13T10:17:05+00:00
Envfile
Datetime2022-09-16T10:25:01.976661+02:002023-02-13T11:24:23.654403+01:00
Hostnamenid00074nid00434
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg msimberg requested a review from aurianer February 13, 2023 10:29
@bors
Copy link
Contributor

bors bot commented Feb 13, 2023

try

Build succeeded:

@aurianer
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 13, 2023

Build succeeded:

@bors bors bot merged commit ca2b493 into pika-org:main Feb 13, 2023
@msimberg msimberg mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

@aurianer aurianer Awaiting requested review from aurianer aurianer is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@msimberg @pika-bot @aurianer