Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up string_util module #595

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Clean up string_util module #595

merged 2 commits into from
Feb 14, 2023

Conversation

aurianer
Copy link
Contributor

Part of #16

@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
pika Commit190f189243cbde
pika Datetime2022-09-16T08:18:06+00:002023-02-13T18:20:50+00:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clusternamedaintdaint
Datetime2022-09-16T10:25:01.976661+02:002023-02-13T19:29:10.061236+01:00
Envfile
Hostnamenid00074nid00012

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg msimberg changed the title Clean up string_util Clean up string_util module Feb 14, 2023
@aurianer
Copy link
Contributor Author

Still WIP, need to move some more symbols in the detail namespace

@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
pika Commit190f189e42ac83
pika Datetime2022-09-16T08:18:06+00:002023-02-14T15:22:38+00:00
Hostnamenid00074nid00025
Datetime2022-09-16T10:25:01.976661+02:002023-02-14T16:29:35.638110+01:00
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@aurianer aurianer force-pushed the clean_up_string_util branch from 3070f6f to 750ce6b Compare February 14, 2023 15:30
@aurianer aurianer mentioned this pull request Feb 14, 2023
Open
59 tasks
@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Feb 14, 2023
@bors
Try #595:
2a78b03
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch---

Info

PropertyBeforeAfter
pika Datetime2022-09-16T08:18:06+00:002023-02-14T15:30:36+00:00
pika Commit190f189148c30f
Hostnamenid00074nid00025
Clusternamedaintdaint
Datetime2022-09-16T10:25:01.976661+02:002023-02-14T16:39:13.698429+01:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@bors
Copy link
Contributor

bors bot commented Feb 14, 2023

try

Build succeeded:

@msimberg
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 14, 2023

Build succeeded:

@bors bors bot merged commit 1250cbe into pika-org:main Feb 14, 2023
@msimberg msimberg added this to the 0.13.0 milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aurianer @pika-bot @msimberg