Update stdexec #597

msimberg · 2023-02-14T16:53:46Z

This PR:

Adds environments to senders and moves completion schedulers into the environments
Enables a few tests that were previously disabled with stdexec (bulk now has a default implementation and split now supports non-copyable senders)
Fixes the completion signatures of when_all_vector (it did not handle set_stopped correctly; this became a hard error with the newer stdexec)

To do:

Update Jenkins CI environments
Opt-in to sender/receiver concepts with is_sender/receiver typedefs

msimberg · 2023-02-14T16:53:53Z

bors try

bors · 2023-02-14T16:54:22Z

try

Build failed:

github/linux/debug/fast

pika-bot · 2023-02-14T16:59:35Z

Performance test report

pika Performance

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
pika Datetime	2022-09-16T08:18:06+00:00	2023-02-14T16:53:48+00:00
pika Commit	`190f189`	`a26174f`
Datetime	2022-09-16T10:25:01.976661+02:00	2023-02-14T17:59:20.289845+01:00
Hostname	nid00074	nid00020
Envfile
Compiler	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clustername	daint	daint

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (>10%)
++/--	Large performance improvement/degradation (>10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

msimberg · 2023-02-15T12:31:32Z

bors try

bors · 2023-02-15T12:32:26Z

try

Build failed:

ci/circleci: clang_format

pika-bot · 2023-02-15T13:33:15Z

Performance test report

pika Performance

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
pika Commit	`190f189`	`d7f01c3`
pika Datetime	2022-09-16T08:18:06+00:00	2023-02-15T13:20:22+00:00
Compiler	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostname	nid00074	nid00025
Clustername	daint	daint
Envfile
Datetime	2022-09-16T10:25:01.976661+02:00	2023-02-15T14:32:54.524946+01:00

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (>10%)
++/--	Large performance improvement/degradation (>10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

msimberg · 2023-02-15T13:39:31Z

bors try

bors · 2023-02-15T13:41:01Z

try

Build failed:

github/linux/fetchcontent/fast

msimberg · 2023-02-15T13:56:05Z

bors try

bors · 2023-02-15T13:57:38Z

try

Build failed:

github/linux/fetchcontent/fast

msimberg · 2023-02-15T14:32:36Z

bors try

bors · 2023-02-15T14:36:15Z

try

Build failed:

jenkins/cscs-ault/hipcc-release

pika-bot · 2023-02-15T14:37:53Z

Performance test report

pika Performance

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
pika Datetime	2022-09-16T08:18:06+00:00	2023-02-15T14:25:23+00:00
pika Commit	`190f189`	`ed61579`
Datetime	2022-09-16T10:25:01.976661+02:00	2023-02-15T15:37:25.385377+01:00
Compiler	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clustername	daint	daint
Envfile
Hostname	nid00074	nid00438

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (>10%)
++/--	Large performance improvement/degradation (>10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

pika-bot · 2023-02-15T14:49:45Z

Performance test report

pika Performance

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
pika Commit	`190f189`	`4953726`
pika Datetime	2022-09-16T08:18:06+00:00	2023-02-15T14:42:19+00:00
Envfile
Hostname	nid00074	nid00025
Datetime	2022-09-16T10:25:01.976661+02:00	2023-02-15T15:49:22.236403+01:00
Compiler	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clustername	daint	daint

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (>10%)
++/--	Large performance improvement/degradation (>10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

pika-bot · 2023-02-15T14:54:50Z

Performance test report

pika Performance

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
pika Commit	`190f189`	`d2bbf43`
pika Datetime	2022-09-16T08:18:06+00:00	2023-02-15T14:50:18+00:00
Datetime	2022-09-16T10:25:01.976661+02:00	2023-02-15T15:54:36.201292+01:00
Envfile
Hostname	nid00074	nid00025
Compiler	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clustername	daint	daint

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (>10%)
++/--	Large performance improvement/degradation (>10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

msimberg · 2023-02-15T14:59:31Z

bors try

msimberg · 2023-02-17T13:58:39Z

bors try

pika-bot · 2023-02-17T14:05:06Z

Performance test report

pika Performance

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
pika Datetime	2022-09-16T08:18:06+00:00	2023-02-17T13:58:35+00:00
pika Commit	`190f189`	`4bf380f`
Datetime	2022-09-16T10:25:01.976661+02:00	2023-02-17T15:04:47.886966+01:00
Envfile
Compiler	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clustername	daint	daint
Hostname	nid00074	nid00025

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (>10%)
++/--	Large performance improvement/degradation (>10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

bors · 2023-02-17T14:11:49Z

try

Build failed:

jenkins/cscs-daint/gcc-cuda-debug

…hen, and schedule_from

pika-bot · 2023-02-20T13:59:42Z

Performance test report

pika Performance

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
pika Commit	`190f189`	`7f05233`
pika Datetime	2022-09-16T08:18:06+00:00	2023-02-20T13:35:20+00:00
Hostname	nid00074	nid00025
Datetime	2022-09-16T10:25:01.976661+02:00	2023-02-20T14:59:16.223326+01:00
Clustername	daint	daint
Compiler	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (>10%)
++/--	Large performance improvement/degradation (>10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

msimberg · 2023-02-20T14:36:46Z

bors try

pika-bot · 2023-02-20T14:50:03Z

Performance test report

pika Performance

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	---

Info

Property	Before	After
pika Datetime	2022-09-16T08:18:06+00:00	2023-02-20T14:36:23+00:00
pika Commit	`190f189`	`3092675`
Datetime	2022-09-16T10:25:01.976661+02:00	2023-02-20T15:49:51.903457+01:00
Compiler	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1	/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostname	nid00074	nid00025
Clustername	daint	daint
Envfile

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (>10%)
++/--	Large performance improvement/degradation (>10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

bors · 2023-02-20T14:56:15Z

try

Build failed:

ci/circleci: arm64_build

msimberg · 2023-02-20T15:14:28Z

These may be introduced by these changes, so will do some more tests: https://cdash.cscs.ch/viewTest.php?onlyfailed&buildid=69588. Otherwise this is finally close to ready.

msimberg · 2023-02-21T08:47:32Z

bors try

bors · 2023-02-21T11:53:09Z

try

Timed out.

msimberg · 2023-02-22T09:16:31Z

bors try

bors · 2023-02-22T09:28:05Z

try

Build failed:

jenkins/cscs-daint/clang-13-release

msimberg · 2023-02-22T11:10:01Z

The failing test is due to #601.

aurianer

LGTM thanks!

msimberg · 2023-02-22T15:45:26Z

bors try

bors · 2023-02-22T16:10:41Z

try

Build succeeded:

msimberg · 2023-02-23T11:02:26Z

bors merge

bors · 2023-02-23T11:39:12Z

Build succeeded:

msimberg added this to the 0.13.0 milestone Feb 14, 2023

msimberg self-assigned this Feb 14, 2023

bors bot added a commit that referenced this pull request Feb 14, 2023

Try #597:

5ef676f

bors bot added a commit that referenced this pull request Feb 15, 2023

Try #597:

e5f0c63

msimberg force-pushed the stdexec-update-sender-env branch from e6606f2 to 9ec6504 Compare February 15, 2023 13:20

msimberg force-pushed the stdexec-update-sender-env branch 2 times, most recently from 055c354 to 12d685c Compare February 15, 2023 13:39

bors bot added a commit that referenced this pull request Feb 15, 2023

Try #597:

c57f7e1

bors bot added a commit that referenced this pull request Feb 15, 2023

Try #597:

5600df5

pika-org deleted a comment from bors bot Feb 15, 2023

msimberg force-pushed the stdexec-update-sender-env branch from e4a27ab to 4e7da7d Compare February 15, 2023 14:25

bors bot added a commit that referenced this pull request Feb 15, 2023

Try #597:

2274a34

msimberg force-pushed the stdexec-update-sender-env branch from 4e7da7d to d09d53a Compare February 15, 2023 14:42

msimberg force-pushed the stdexec-update-sender-env branch from d09d53a to 7a2bb08 Compare February 15, 2023 14:50

msimberg force-pushed the stdexec-update-sender-env branch from d3cbd08 to 5458ad2 Compare February 17, 2023 13:58

bors bot added a commit that referenced this pull request Feb 17, 2023

Try #597:

5b13355

Fix a few environment handling problems with thread_pool_scheduler, t…

864f82a

…hen, and schedule_from

Decay sender type before checking concept in transform_mpi

967bcf0

bors bot added a commit that referenced this pull request Feb 20, 2023

Try #597:

93511bd

bors bot added a commit that referenced this pull request Feb 21, 2023

Try #597:

5350202

bors bot added a commit that referenced this pull request Feb 22, 2023

Try #597:

edfd613

msimberg marked this pull request as ready for review February 22, 2023 11:10

msimberg requested review from aurianer and biddisco as code owners February 22, 2023 11:10

aurianer approved these changes Feb 22, 2023

View reviewed changes

bors bot added a commit that referenced this pull request Feb 22, 2023

Try #597:

aa63735

bors bot merged commit 4a8391b into pika-org:main Feb 23, 2023

Update stdexec #597

Update stdexec #597

Conversation

msimberg commented Feb 14, 2023 • edited Loading

msimberg commented Feb 14, 2023

bors bot commented Feb 14, 2023

try

pika-bot commented Feb 14, 2023

pika Performance

Comparison

Info

Explanation of Symbols

msimberg commented Feb 15, 2023

bors bot commented Feb 15, 2023

try

pika-bot commented Feb 15, 2023

pika Performance

Comparison

Info

Explanation of Symbols

msimberg commented Feb 15, 2023

bors bot commented Feb 15, 2023

try

msimberg commented Feb 15, 2023

bors bot commented Feb 15, 2023

try

msimberg commented Feb 15, 2023

bors bot commented Feb 15, 2023

try

pika-bot commented Feb 15, 2023

pika Performance

Comparison

Info

Explanation of Symbols

pika-bot commented Feb 15, 2023

pika Performance

Comparison

Info

Explanation of Symbols

pika-bot commented Feb 15, 2023

pika Performance

Comparison

Info

Explanation of Symbols

msimberg commented Feb 15, 2023

msimberg commented Feb 17, 2023

pika-bot commented Feb 17, 2023

pika Performance

Comparison

Info

Explanation of Symbols

bors bot commented Feb 17, 2023

try

pika-bot commented Feb 20, 2023

pika Performance

Comparison

Info

Explanation of Symbols

msimberg commented Feb 20, 2023

pika-bot commented Feb 20, 2023

pika Performance

Comparison

Info

Explanation of Symbols

bors bot commented Feb 20, 2023

try

msimberg commented Feb 20, 2023

msimberg commented Feb 21, 2023

bors bot commented Feb 21, 2023

try

msimberg commented Feb 22, 2023

bors bot commented Feb 22, 2023

try

msimberg commented Feb 22, 2023

aurianer left a comment

Choose a reason for hiding this comment

msimberg commented Feb 22, 2023

bors bot commented Feb 22, 2023

try

msimberg commented Feb 23, 2023

msimberg commented Feb 14, 2023 •

edited

Loading