Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up schedulers module #625

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Clean up schedulers module #625

merged 1 commit into from
Mar 27, 2023

Conversation

aurianer
Copy link
Contributor

Fixes partially #16.

@aurianer aurianer added this to the 0.14.0 milestone Mar 24, 2023
@aurianer aurianer self-assigned this Mar 24, 2023
@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Mar 24, 2023
@bors
Try #625:
c6e3b75
@bors
Copy link
Contributor

bors bot commented Mar 24, 2023

try

Build failed:

@aurianer aurianer force-pushed the clean_up_schedulers branch from 1aff673 to dfbad41 Compare March 24, 2023 11:00
@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Mar 24, 2023
@bors
Try #625:
720e589
@bors
Copy link
Contributor

bors bot commented Mar 24, 2023

try

Build failed:

@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
pika Commit190f18958924cf
pika Datetime2022-09-16T08:18:06+00:002023-03-24T11:00:03+00:00
Clusternamedaintdaint
Hostnamenid00074nid00552
Envfile
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Datetime2022-09-16T10:25:01.976661+02:002023-03-24T12:17:45.899742+01:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@aurianer aurianer force-pushed the clean_up_schedulers branch from dfbad41 to 8f9bc9b Compare March 24, 2023 14:54
@aurianer aurianer mentioned this pull request Mar 24, 2023
Open
59 tasks
@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Mar 24, 2023
@bors
Try #625:
756ef56
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
pika Commit190f189da0dd0e
pika Datetime2022-09-16T08:18:06+00:002023-03-24T14:54:17+00:00
Datetime2022-09-16T10:25:01.976661+02:002023-03-24T15:59:33.203590+01:00
Clusternamedaintdaint
Envfile
Hostnamenid00074nid00692
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@bors
Copy link
Contributor

bors bot commented Mar 24, 2023

try

Build succeeded:

@msimberg msimberg mentioned this pull request Mar 27, 2023
Merged
msimberg
msimberg approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@msimberg
Copy link
Contributor

bors merge

bors bot added a commit that referenced this pull request Mar 27, 2023
@bors @aurianer
Merge #625
fda115d 
625: Clean up schedulers module r=msimberg a=aurianer

Fixes partially #16.

Co-authored-by: aurianer <aurianer@cscs.ch>
@msimberg
Copy link
Contributor

Note that I've fixed the codacy warnings in #628.

@bors
Copy link
Contributor

bors bot commented Mar 27, 2023

Build failed:

@msimberg
Copy link
Contributor

bors merge p=5

@bors
Copy link
Contributor

bors bot commented Mar 27, 2023

Build succeeded:

@bors bors bot merged commit b00c8cb into pika-org:main Mar 27, 2023
@aurianer aurianer deleted the clean_up_schedulers branch April 12, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@aurianer aurianer

Labels
type: cleanup
Projects
pika planning board
Archived in project
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aurianer @pika-bot @msimberg